Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

[Jon Mason]

On Tue, Dec 5, 2017 at 12:01 PM, Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:
>
>
> On 05/12/17 09:52 AM, Jon Mason wrote:
>>
>> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin <fancer.lancer@xxxxxxxxx>
>> wrote:
>>>
>>> Simple (1 << pidx) operation causes undefined behaviour when
>>> pidx >= 32. It must be casted to u64 to match the actual return
>>> value of ntb_link_is_up() method, so to have all the possible
>>> peer indexes covered and to get rid of undefined behaviour.
>>> Additionally there are special macros in "linux/bitops.h" to perform
>>> the bit-set-shift operations, so it's recommended to have them used
>>> for proper bit setting.
>>
>>
>> This looks good to me, but also seems like a bug fix.  Please comment
>> on if this is not noticed.
>
>
> It would be a bug on any system that has more than 32 partitions which is
> run on a 32 bit machine (or 64 partitions on a 64bit machine). Such a system
> is theoretical for the foreseeable future. But it would be good to fix it
> now.

Seems like a non-issue then.  Disregard.

>
> Logan
>
> --
> You received this message because you are subscribed to the Google Groups
> "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to linux-ntb+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to linux-ntb@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/linux-ntb/8859c11b-6c6b-3780-c13a-2ae0affd7033%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.