Re: ipmi null pointer oops in 4.15-rc2+ on HP DL360G6

[Corey Minyard]

On 12/07/2017 09:43 AM, Meelis Roos wrote:
> > > Tried current 4.15 git on HP DL360G6 (working fine in 4.14), got null
> > > pointer dereference oops from ipmi_pci_probe (or so it seems from the
> > > backtrace).
> > I have a fix for this at https://bugzilla.kernel.org/show_bug.cgi?id=197999,
> > but
> > the reported hasn't reported if the patch there fixes the issue. If you could
> > test
> > this, that would be very helpful.
> It works. no errors. I hve not tested if ipmi communication actually
> works though.

Ok. I added pci support to the qemu IPMI stuff and tested it myself. 
But thanks,
I'll add your "Tested by". It's good to have more testers.

-corey

> $ dmesg |grep -i pmi
> [    0.000000] ACPI: SPMI 0x00000000D761F2C0 000040 (v05 HP     ProLiant 00000001 \xd2?   0000162E)
> [    4.563949] ipmi message handler version 39.2
> [    4.578919] ipmi device interface
> [    4.580438] IPMI System Interface driver.
> [    4.580503] ipmi_si dmi-ipmi-si.0: ipmi_platform: probing via SMBIOS
> [    4.580561] ipmi_si: SMBIOS: io 0xca2 regsize 1 spacing 1 irq 0
> [    4.580618] ipmi_si: Adding SMBIOS-specified kcs state machine
> [    4.580687] ipmi_si IPI0001:00: ipmi_platform: probing via ACPI
> [    4.580758] ipmi_si IPI0001:00: [io  0x0ca2-0x0ca3] regsize 1 spacing 1 irq 0
> [    4.580817] ipmi_si dmi-ipmi-si.0: Removing SMBIOS-specified kcs state machine in favor of ACPI
> [    4.580894] ipmi_si: Adding ACPI-specified kcs state machine
> [    4.580964] ipmi_platform: probing via SPMI
> [    4.581018] ipmi_si: SPMI: io 0xca2 regsize 2 spacing 2 irq 0
> [    4.581074] (NULL device *): SPMI-specified kcs state machine: duplicate
> [    4.581142] ipmi_si 0000:01:04.6: probing via PCI
> [    4.581282] ipmi_si 0000:01:04.6: [mem 0xf5ef0000-0xf5ef00ff] regsize 1 spacing 1 irq 21
> [    4.581356] ipmi_si: Adding PCI-specified kcs state machine
> [    4.581428] ipmi_si: Trying PCI-specified kcs state machine at mem address 0xf5ef0000, slave address 0x0, irq 21
> [    5.112453] ipmi_si 0000:01:04.6: Using irq 21
> [    5.127593] ipmi_si 0000:01:04.6: Found new BMC (man_id: 0x00000b, prod_id: 0x2000, dev_id: 0x11)
> [    5.139340] ipmi_si 0000:01:04.6: IPMI kcs interface initialized
> [    5.148318] IPMI SSIF Interface driver
> [    6.126894] ACPI Error: SMBus/IPMI/GenericSerialBus write requires Buffer of length 66, found length 32 (20170831/exfield-427)
> [    6.127233] ACPI Error: Method parse/execution failed \_SB.PMI0._PMM, AE_AML_BUFFER_LIMIT (20170831/psparse-550)