Re: [PATCH 00/18] crypto: talitos - fixes and performance improvement

From: Horia Geantă
Date: Fri Dec 08 2017 - 10:20:51 EST


On 10/12/2017 6:20 PM, Herbert Xu wrote:
> On Fri, Oct 06, 2017 at 03:04:31PM +0200, Christophe Leroy wrote:
>> This serie fixes and improves the talitos crypto driver.
>>
>> First 6 patchs are fixes of failures reported by the new tests in the
>> kernel crypto test manager.
>>
Looks like these fixes are required also on older 4.9+ -stable kernels.
(I haven't seen them on latest 4.9.68-stable mail from Greg, even though
they are in main tree.)

In case you agree, what would be the recommended way to add the patches
to -stable?

Thanks,
Horia

>> The 8 following patches are cleanups and simplifications.
>>
>> The last 4 ones are performance improvement. The main improvement is
>> in the one before the last, it divides by 2 the time needed for a md5
>> hash on the SEC1.
>>
>> Christophe Leroy (18):
>> crypto: talitos - fix AEAD test failures
>> crypto: talitos - fix memory corruption on SEC2
>> crypto: talitos - fix setkey to check key weakness
>> crypto: talitos - fix AEAD for sha224 on non sha224 capable chips
>> crypto: talitos - fix use of sg_link_tbl_len
>> crypto: talitos - fix ctr-aes-talitos
>> crypto: talitos - zeroize the descriptor with memset()
>> crypto: talitos - declare local functions static
>> crypto: talitos - use devm_kmalloc()
>> crypto: talitos - use of_property_read_u32()
>> crypto: talitos - use devm_ioremap()
>> crypto: talitos - don't check the number of channels at each interrupt
>> crypto: talitos - remove to_talitos_ptr_len()
>> crypto: talitos - simplify tests in ipsec_esp()
>> crypto: talitos - DMA map key in setkey()
>> crypto: talitos - do hw_context DMA mapping outside the requests
>> crypto: talitos - chain in buffered data for ahash on SEC1
>> crypto: talitos - avoid useless copy
>
> All applied. Thanks.
>