Re: [PATCH 4.4 38/49] xen-netfront: Improve error handling during initialization

[Greg Kroah-Hartman]

On Fri, Dec 08, 2017 at 05:10:49AM +0000, Ben Hutchings wrote:
> On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me
> > know.
> > 
> > ------------------
> > 
> > From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > 
> > 
> > [ Upstream commit e2e004acc7cbe3c531e752a270a74e95cde3ea48 ]
> [...]
> > @@ -1950,9 +1942,10 @@ abort_transaction_no_dev_fatal:
> >  	xenbus_transaction_end(xbt, 1);
> >   destroy_ring:
> >  	xennet_disconnect_backend(info);
> > -	kfree(info->queues);
> > -	info->queues = NULL;
> > +	xennet_destroy_queues(info);
> >   out:
> > +	unregister_netdev(info->netdev);
> > +	xennet_free_netdev(info->netdev);
> >  	return err;
> >  }
> 
> This last bit of cleanup looks wrong.  It was subsequently changed
> upstream by:
> 
> 86b5672b1adb xen-netfront: avoid crashing on resume after a failure in talk_to_netback()

Good catch, but it's d86b5672b1ad ("xen-netfront: avoid crashing on
resume after a failure in talk_to_netback()")

:)

thanks,

greg k-h