Re: [PATCH v8 2/2] media: i2c: Add the ov7740 image sensor driver

[Yang, Wenyou]

Hi Philippe,


On 2017/12/8 21:14, Philippe Ombredanne wrote:
> Wenyou,
>
> On Fri, Dec 8, 2017 at 2:55 AM, Wenyou Yang <wenyou.yang@xxxxxxxxxxxxx> wrote:
> > The ov7740 (color) image sensor is a high performance VGA CMOS
> > image snesor, which supports for output formats: RAW RGB and YUV
> > and image sizes: VGA, and QVGA, CIF and any size smaller.
> >
> > Signed-off-by: Songjun Wu <songjun.wu@xxxxxxxxxxxxx>
> > Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxxxxxx>
> []
> > --- /dev/null
> > +++ b/drivers/media/i2c/ov7740.c
> > @@ -0,0 +1,1226 @@
> > +/*
> > + * Copyright (c) 2017 Microchip Corporation.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License version
> > + * 2 as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + */
> Have you considered using the new SPDX ids instead of this fine legalese?
> e.g.:
>
> // SPDX-License-Identifier: GPL-2.0
> // Copyright (c) 2017 Microchip Corporation.
>
> Short and neat! Check also Thomas doc patches and Linus comments on
> why he prefers the C++ comment style for these.
Thank you for your suggestion and information.


Best Regards,
Wenyou Yang