Re: [PATCH v5] kernel: make groups_sort calling a responsibility group_info allocators

[Matthew Wilcox]

On Mon, Dec 11, 2017 at 01:14:20PM -0200, Thiago Rafael Becker wrote:
> In testing, we found that nfsd threads may call set_groups in parallel for
> the same entry cached in auth.unix.gid, racing in the call of groups_sort,
> corrupting the groups for that entry and leading to permission denials for
> the client.
> 
> This patch:
>  - Make groups_sort globally visible.
>  - Move the call to groups_sort to the modifiers of group_info
>  - Remove the call to groups_sort from set_groups
> 
> Signed-off-by: Thiago Rafael Becker <thiago.becker@xxxxxxxxx>

Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>