Re: [GIT PULL] SCSI fixes for 4.15-rc3

From: James Bottomley
Date: Tue Dec 12 2017 - 12:30:36 EST


On Tue, 2017-12-12 at 12:22 -0500, Martin K. Petersen wrote:
> Linus,
>
> >
> > This is utter shite, and doesn't even compile cleanly.
> >
> > Sure, it's "just" a warning, and the code works. But no, I'm not
> > pulling crap like this. If you save a pointer in an integer
> > "hostdata[0]" field, then you damn well do the proper casts or
> > helper
> > functions or something, you don't just ignore the compiler when it
> > very reasonably warns about it.
> >
> > What the hell is going on? Nobody compiled this stuff at all? Or
> > nobody cares about new build warnings?
>
> Arnd and Johannes fixed this up right away:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?
> h=fixes&id=45349821ab3a8d378b8f37e52c6fe1aa1b870c47

Yes, I have that in the current testing batch, how about I push the
combined thing on wednesday.

James