RE: [PATCH V3 net-next 3/8] net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support

From: Salil Mehta
Date: Wed Dec 13 2017 - 08:02:49 EST


Hi Philippe,

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx]
> Sent: Wednesday, December 13, 2017 12:54 PM
> To: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Zhuangyuzeng (Yisen)
> <yisen.zhuang@xxxxxxxxxx>; lipeng (Y) <lipeng321@xxxxxxxxxx>; Salil
> Mehta <mehta.salil.lnk@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; LKML <linux-
> kernel@xxxxxxxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Linuxarm
> <linuxarm@xxxxxxxxxx>
> Subject: Re: [PATCH V3 net-next 3/8] net: hns3: Add HNS3 VF
> HCL(Hardware Compatibility Layer) Support
>
> Dear Salil,
>
> On Wed, Dec 13, 2017 at 11:35 AM, Salil Mehta <salil.mehta@xxxxxxxxxx>
> wrote:
>
> > I could also make out from different articles, including from the
> below,
> > Linus suggesting moving to "//" type instead of starred ones for
> headers.
> >
> > It looks SPDX change is still a suggestion?
>
> Well, I think this has been discussed and agreed among maintainers at
> the plumbers summit and here on this list. And when I see Thomas doc
> patches, Greg patches, other key maintainers as well as Linus comments
> and reviews and guidelines, I can can hardly see this as just being a
> "suggestion", but that's your call to consider it this way.
Ok. I understand. Thanks for confirming it. I will do the changes as
suggested by you and thanks for bringing this into notice.

Best regards
Salil