Re: [PATCH] leds: as3645a: Fix checkpatch warnings

From: Jacek Anaszewski
Date: Wed Dec 13 2017 - 15:44:20 EST


Dan,

On 12/13/2017 09:41 PM, Dan Murphy wrote:
> Jacek
>
> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
>> Hi Dan,
>>
>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
>>
>
> Ack
>
>> "WARNING: A patch subject line should describe the change not the tool
>> that found it"
>>
>> Preferably I'd see two separate patches.
>>
>
> So you want me to split them up? I have no issue with that.

Yeah, it will be easier to come up with concise but meaningful
subjects.

>> Also, line length limit for the commit description is 75 characters.
>> Please use whole available space.
>>
>
>

--
Best regards,
Jacek Anaszewski