Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

From: David Miller
Date: Wed Dec 13 2017 - 22:34:40 EST


From: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
Date: Thu, 14 Dec 2017 11:13:15 +0800

> Thanks for reply :)
> I think I should use "udelay(100000/HZ)" instead, do you think it is
> right?

The delay is too long, please do not ignore that part of my critique
of your change.

You cannot delay so long under a lock, that's why the code is trying
to use a sleeping delay.

I'm not going to explain this problem another time.