RE: [PATCH v8 2/2] mtd: nand: Add support for Arasan NAND Flash Controller

From: Naga Sureshkumar Relli
Date: Thu Dec 14 2017 - 06:31:47 EST


Hi Philippe,

Thanks for the review.
I will update it in next version.

Thanks,
Naga Sureshkumar Relli.

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx]
> Sent: Thursday, December 14, 2017 2:42 PM
> To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> Cc: boris.brezillon@xxxxxxxxxxxxxxxxxx; richard@xxxxxx;
> computersforpeace@xxxxxxxxx; marek.vasut@xxxxxxxxx;
> cyrille.pitchen@xxxxxxxxxx; dwmw2@xxxxxxxxxxxxx; linux-
> mtd@xxxxxxxxxxxxxxxxxxx; LKML <linux-kernel@xxxxxxxxxxxxxxx>; Michal Simek
> <michals@xxxxxxxxxx>; Punnaiah Choudary Kalluri <punnaia@xxxxxxxxxx>;
> nagasuresh12@xxxxxxxxx
> Subject: Re: [PATCH v8 2/2] mtd: nand: Add support for Arasan NAND Flash
> Controller
>
> Dear Naga,
>
> On Thu, Dec 14, 2017 at 8:49 AM, Naga Sureshkumar Relli
> <naga.sureshkumar.relli@xxxxxxxxxx> wrote:
> > Added the basic driver for Arasan NAND Flash Controller used in Zynq
> > UltraScale+ MPSoC. It supports only Hw ECC and upto 24bit correction.
> >
> > Signed-off-by: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xxxxxxxxxx>
>
> <snip>
>
> > --- /dev/null
> > +++ b/drivers/mtd/nand/arasan_nand.c
> > @@ -0,0 +1,1020 @@
> > +/*
> > + * Arasan NAND Flash Controller Driver
> > + *
> > + * Copyright (C) 2014 - 2017 Xilinx, Inc.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > +modify it under
> > + * the terms of the GNU General Public License version 2 as published
> > +by the
> > + * Free Software Foundation; either version 2 of the License, or (at
> > +your
> > + * option) any later version.
> > + */
>
> Could you use the new SPDX tags instead of this fine and long boilerplate? See
> Thomas doc for details [1]
>
> [1] https://lkml.org/lkml/2017/12/4/934
>
> Thanks!
>
> --
> Cordially
> Philippe Ombredanne