Re: [PATCH] leds: as3645a: Fix checkpatch warnings

From: Pavel Machek
Date: Thu Dec 14 2017 - 17:50:49 EST


On Wed 2017-12-13 14:49:38, Dan Murphy wrote:
> Pavel and Laurent
>
> On 12/13/2017 02:43 PM, Jacek Anaszewski wrote:
> > Dan,
> >
> > On 12/13/2017 09:41 PM, Dan Murphy wrote:
> >> Jacek
> >>
> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
> >>> Hi Dan,
> >>>
> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
> >>>
> >>
> >> Ack
> >>
> >>> "WARNING: A patch subject line should describe the change not the tool
> >>> that found it"
> >>>
> >>> Preferably I'd see two separate patches.
> >>>
> >>
> >> So you want me to split them up? I have no issue with that.
> >
> > Yeah, it will be easier to come up with concise but meaningful
> > subjects.
> >
>
> When I split these up can I add your Acked-by to each patch or would you prefer to resend your
> Acked-by for each patch?

You can keep the ack...

...and my preference would be for trivial fixes like these to be just
applied. No need to resend 3 versions etc...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature