Re: [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt

From: Joe Perches
Date: Tue Dec 19 2017 - 11:14:32 EST


On Tue, 2017-12-19 at 17:12 +0100, Peter Zijlstra wrote:
> On Tue, Dec 19, 2017 at 08:09:53AM -0800, Joe Perches wrote:
> >
> > I suspect you need to define this as:
> >
> > #define int_sqrt64(x) ((u32)int_sqrt(x))
>
> What's wrong with using C ?

Duh. Nothing at all.

> static inline u32 int_sqrt64(u64 x)
> {
> return int_sqrt(x);
> }