Re: platform/x86/thinkpad_acpi: Adjustments for four function implementations

From: SF Markus Elfring
Date: Tue Dec 19 2017 - 11:24:20 EST


>> Delete an error message for a failed memory allocation in three functions
>
> This one is questionable since it prints error messages at ->init() stage.
> I would rather not touch this.

Do you find the Linux allocation failure report insufficient in this case?


>> Improve a size determination in tpacpi_new_rfkill()
>
> Doesn't make any sense right now. One style over the other.
> Nothing gets better or worth at this point.

Would you like to care for a bit more compliance with information
from the section â14) Allocating memoryâ in the document âcoding-style.rstâ?

Regards,
Markus