Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping

[Mehta, Sohil]

On Tue, 2017-12-19 at 23:30 +0200, Andy Shevchenko wrote:
> On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote:
> > 
> > Debugfs extension for Intel IOMMU to dump Interrupt remapping table
> > entries for Interrupt remapping and Interrupt posting.
> > 
> > The file /sys/kernel/debug/intel_iommu/ir_translation_struct
> > provides
> > detailed information, such as Index, Source Id, Destination Id,
> > Vector
> > and the raw values for entries with the present bit set, in the
> > format
> > shown.
> > 
> > Remapped Interrupt supported on IOMMU: dmar5
> > ÂIR table address:ffff93e09d54c310
> > -----------------------------------------------------------
> > ÂIndexÂÂSIDÂÂDest_IDÂÂVct Raw_value_highÂÂÂRaw_value_low
> > Â1ÂÂÂÂÂÂ3a00 00000600 2cÂÂ0000000000043a00 00000600002c0009
> > Â111ÂÂÂÂ4301 00000900 a2ÂÂ0000000000044301 0000090000a20009
> > 
> > Posted Interrupt supported on IOMMU: dmar5
> > ÂIR table address:ffff93e09d54c310
> > -----------------------------------------------------------------
> > ---
> > ÂIndexÂÂSIDÂÂPDA_high PDA_lowÂÂVct Raw_value_highÂÂÂRaw_value_low
> > Â4ÂÂÂÂÂÂ4300 00000010 40c7c880 41ÂÂ0000001000044300
> > 40c7c88000418001
> > Â5ÂÂÂÂÂÂ4300 00000010 40c7c880 51ÂÂ0000001000044300
> > 40c7c88000518001
> > 
> > 
> > 
> > +		seq_printf(m, "\nRemapped Interrupt supported on
> > IOMMU: %s\n"
> Please, avoid leading \n.

Sure. I'll add a separate seq_puts(m, "\n") after each of the loops to
avoid having the leading '\n's.

> 
> > 
> > +			ÂÂÂ" IR table address:%p\n", iommu->name,
> > +			ÂÂÂiommu->ir_table);
> > +
> > +		seq_puts(m, "-------------------------------------
> > -
> > ---------"
> > +			Â"------------\n");
> It's okay to use long string literal on one line. So, don't split (or
> for multi-line string literals, split by \n like you do above).
> 
Thanks. Will fix this and the other one.

> > 
> > +	seq_puts(m,
> > "\n****\t****\t****\t****\t****\t****\t****\t****\n");
> Leading \n.
> 
> > 
> > +		seq_printf(m, "\nPosted Interrupt supported on
> > IOMMU:
> > %s\n"
> Ditto.
> 
> > 
> > +			ÂÂÂ" IR table address:%p\n", iommu->name,
> > +			ÂÂÂiommu->ir_table);
> > +
> > +		seq_puts(m, "-------------------------------------
> > -
> > ----------"
> > +			Â"--------------------\n");
> Join back.
>