Re: [PATCH RFC 1/3] crypto: Prevent to register duplicate cra_driver_name

From: Herbert Xu
Date: Thu Dec 21 2017 - 01:36:12 EST


On Wed, Dec 20, 2017 at 08:09:25PM +0000, Corentin Labbe wrote:
> Each crypto algorithm "cra_name" can have multiple implementation called
> "cra_driver_name".
> If two different implementation have the same cra_driver_name, nothing
> can easily differentiate them.
> Furthermore the mechanism for getting a crypto algorithm with its
> implementation name (crypto_alg_match() in crypto/crypto_user.c) will
> get only the first one found.
>
> So this patch prevent the registration of two implementation with the
> same cra_driver_name.
>
> Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>

No this is intentional. The idea is that you can hot-replace
an implementation by registering a new version of it while the
old one is still in use. The new one will be used for all new
allocations.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt