Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Thu Dec 21 2017 - 15:51:02 EST


On Thu, Dec 21, 2017 at 09:46:18PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote:
> > On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote:
> > > On Thu, Dec 21, 2017 at 07:05:03PM +0000, Ghorai, Sukumar wrote:
> > > > >>On Thu, Dec 21, 2017 at 06:52:31PM +0000, Ghorai, Sukumar wrote:
> > > > >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O
> > > > >> device connected.
> > > > >
> > > > >Could you ever? If not, that looks like a feature request to me...
> > > > Agree, feature request... however we need this feature for rapid use of Bluetooth LE devices.
> > >
> > > Is that what -stable is for now? For getting your pet feature enabled
> >
> > I sincerely hope not. If -stable now officially supports adding new
> > features, we'll have to revisit our strategy for merging stable releases.
>
> I'm not trying to add any new features at all, this was added because I
> was told it resolved an issue that people had with their hardware.

Wait, I was told by a chromeos developer to do this! Matthias asked for
this patch to be merged to resolve a regression you all found on your
systems. For it to now cause problems seems really "odd" to me...

So you all need to get your story straight here :)

I want all 3 of you (Guenter, Brian, and Matthias) to figure out what is
going on here please before I do _anything_ in the stable trees with
this patch.

greg k-h