Re: [PATCH v2] arch: define weak abort

From: Sudip Mukherjee
Date: Thu Dec 21 2017 - 18:20:45 EST


On Tue, Dec 19, 2017 at 01:55:59PM -0800, Andrew Morton wrote:
> On Tue, 19 Dec 2017 13:39:22 -0800 Vineet Gupta <Vineet.Gupta1@xxxxxxxxxxxx> wrote:
>

<snip>

> > Hmm, I realize there's a small gotcha with this, when testing with a different
> > patch from Arnd. This needs an EXPORT_SYMBOL() as well !
>
> Yup. This?

Yes, just faced this when I was testing with the reverted patch on m32r.

>
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Subject: kernel/exit.c: export abort() to modules
>
> gcc -fisolate-erroneous-paths-dereference can generate calls to abort()
> from modular code too.
>
> Reported-by: Vineet Gupta <Vineet.Gupta1@xxxxxxxxxxxx>
> Cc: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: "Alexey Brodkin" <Alexey.Brodkin@xxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---

Acked-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>

--
Regards
Sudip