Re: [PATCH] gpio: gpio-reg: fix build

From: Geert Uytterhoeven
Date: Sun Dec 24 2017 - 10:50:05 EST


Hi Grygorii,

On Wed, Dec 6, 2017 at 6:37 PM, Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:
> Revert changes introduced by commit f0fbe7bce733 ("gpio: Move irqdomain
> into struct gpio_irq_chip") as they are not aplicable to this driver.
>
> Cc: Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>
> Fixes: f0fbe7bce733 ("gpio: Move irqdomain into struct gpio_irq_chip")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> ---
> Sorry, for inconvenience, but this driver has no users in lkml and
> it can't be enabled through defconfig - only selected, so builds can't
> be verified in standard way.

Seems like we need:

--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -392,7 +392,7 @@ config GPIO_RCAR
Say yes here to support GPIO on Renesas R-Car SoCs.

config GPIO_REG
- bool
+ bool "32-bit single register GPIO fixed in/out support" if COMPILE_TEST
help
A 32-bit single register GPIO fixed in/out implementation. This
can be used to represent any register as a set of GPIO signals.

Any dependencies to be added?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds