Re: [PATCH v3 09/34] clk: bcm2835: change clk_get_rate() helper return type

From: Eric Anholt
Date: Tue Jan 02 2018 - 17:21:53 EST


Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx> writes:

> bcm2835_pll_rate_from_divisor returns a long but the function calling it
> returns an unsigned long. There's no reason to have a type disparity here
> so tidy up the return type of bcm2835_pll_rate_from_divisor() from signed
> to unsigned long.

I'm still surprised that clocks are using longs instead of u64s, but
this seems like a fine change. For the 2 bcm2835 patches,

Reviewed-by: Eric Anholt <eric@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature