Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

From: Wang, Haiyue
Date: Wed Jan 03 2018 - 09:28:32 EST




On 2018-01-03 19:38, Mark Brown wrote:
On Sun, Dec 31, 2017 at 12:10:51AM +0100, Arnd Bergmann wrote:
On Fri, Dec 29, 2017 at 2:53 AM, Haiyue Wang
<haiyue.wang@xxxxxxxxxxxxxxx> wrote:
When PCH works under eSPI mode, the PMC (Power Management Controller) in
PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in
dead loop if no SUS_ACK assert. This is the basic requirement for the BMC
works as eSPI slave.

Also for the host power on / off actions, from BMC side, the following VW
(Virtual Wire) messages are done in firmware:
1. SLAVE_BOOT_LOAD_DONE / SLAVE_BOOT_LOAD_STATUS
2. SUS_ACK
3. OOB_RESET_ACK
4. HOST_RESET_ACK
I have not looked at the driver contents yet, but I'm adding the SPI
maintainer and
mailing list to Cc here for further discussion. Can you clarify how
More generally:

As documented in SubmittingPatches please send patches to the
maintainers for the code you would like to change. The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.
Should send to like this ? Because I add patch for Aspeed chip:

./scripts/get_maintainer.pl drivers/misc/aspeed-lpc-snoop.c
Joel Stanley <joel@xxxxxxxxx> (maintainer:ARM/ASPEED MACHINE SUPPORT)
Arnd Bergmann <arnd@xxxxxxxx> (supporter:CHAR and MISC DRIVERS)
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:CHAR and MISC DRIVERS)
linux-kernel@xxxxxxxxxxxxxxx (open list)