Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

From: Laurent Pinchart
Date: Fri Jan 12 2018 - 05:36:12 EST


Hi Geert,

On Friday, 12 January 2018 11:01:18 EET Geert Uytterhoeven wrote:
> On Fri, Jan 12, 2018 at 12:12 AM, Laurent Pinchart wrote:
> > On Tuesday, 9 January 2018 18:25:25 EET Jacopo Mondi wrote:
> >> Add driver for Renesas Capture Engine Unit (CEU).
> >>
> >> The CEU interface supports capturing 'data' (YUV422) and 'images'
> >> (NV[12|21|16|61]).
> >>
> >> This driver aims to replace the soc_camera-based sh_mobile_ceu one.
> >>
> >> Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ
> >> platform GR-Peach.
> >>
> >> Tested with ov7725 camera sensor on SH4 platform Migo-R.
> >>
> >> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> >> ---
> >>
> >> drivers/media/platform/Kconfig | 9 +
> >> drivers/media/platform/Makefile | 1 +
> >> drivers/media/platform/renesas-ceu.c | 1648 ++++++++++++++++++++++++++++
> >> 3 files changed, 1658 insertions(+)
> >>
> >> create mode 100644 drivers/media/platform/renesas-ceu.c
> >
> > [snip]
> >
> >> diff --git a/drivers/media/platform/renesas-ceu.c
> >> b/drivers/media/platform/renesas-ceu.c new file mode 100644
> >> index 0000000..d261704
> >> --- /dev/null
> >> +++ b/drivers/media/platform/renesas-ceu.c
> >> @@ -0,0 +1,1648 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >
> > It was recently brought to my attention that SPDX headers should use
> > either GPL-2.0-only or GPL-2.0-or-later, no the ambiguous GPL-2.0. Could
> > you please update all patches in this series ?
>
> IMHO it's a bit premature to do that.
> As long as Documentation/process/license-rules.rst isn't updated, I wouldn't
> follow this change.
>
> See also https://www.spinics.net/lists/linux-xfs/msg14536.html

Thank you for bringing this to my attention. I agree with you.

--
Regards,

Laurent Pinchart