[PATCH] staging: unisys: change select to depends for subsystems

From: Randy Dunlap
Date: Mon Jan 15 2018 - 00:11:47 EST


From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: David Kershner <david.kershner@xxxxxxxxxx>
Cc: sparmaintainer@xxxxxxxxxx (Unisys internal)
Cc: devel@xxxxxxxxxxxxxxxxxxxx
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/staging/unisys/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
+++ lnx-415-rc8/drivers/staging/unisys/Kconfig
@@ -4,8 +4,7 @@
menuconfig UNISYSSPAR
bool "Unisys SPAR driver support"
depends on X86_64 && !UML
- select PCI
- select ACPI
+ depends on PCI && ACPI
---help---
Support for the Unisys SPAR drivers