Re: [PATCH 3/4] x86/jump_label: Implement arch_static_assert()

[Peter Zijlstra]

On Mon, Jan 15, 2018 at 11:22:12AM -0600, Josh Poimboeuf wrote:
> On Mon, Jan 15, 2018 at 05:44:31PM +0100, Peter Zijlstra wrote:


> > +static __always_inline void arch_static_assert(void)
> > +{
> > +	asm volatile ("1:\n\t"
> > +		      ".pushsection .discard.jump_assert, \"aw\" \n\t"
> > +		      _ASM_ALIGN  "\n\t"
> > +		      _ASM_PTR "1b \n\t"
> > +		      ".popsection \n\t");
> > +}
> > +
> 
> This needs a nice comment about what exactly it asserts.

Right, I'll go write one, if you don't see anything horrendous in the
objtool code ofcourse :-)

> And also, people without objtool enabled (i.e., no ORC or livepatch)
> won't see the assertion.  Do we care about those people? :-)

Nah, we should get plenty of build coverage with the others I think.