Re: [patch v16 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver

From: Joel Stanley
Date: Mon Jan 15 2018 - 15:31:56 EST


On Fri, Jan 12, 2018 at 11:08 AM, Oleksandr Shamray
<oleksandrs@xxxxxxxxxxxx> wrote:
> It has been tested on Mellanox system with BMC equipped with
> Aspeed 2520 SoC for programming CPLD devices.
>
> Signed-off-by: Oleksandr Shamray <oleksandrs@xxxxxxxxxxxx>
> Signed-off-by: Jiri Pirko <jiri@xxxxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>

For the device tree bindings:

Acked-by: Joel Stanley <joel@xxxxxxxxx>

> diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c
> index 9cbd6da..f679041 100644
> --- a/drivers/jtag/jtag-aspeed.c
> +++ b/drivers/jtag/jtag-aspeed.c
> @@ -12,6 +12,7 @@
> #include <linux/module.h>
> #include <linux/of_address.h>
> #include <linux/platform_device.h>
> +#include <linux/reset.h>

Oops, this is in the wrong patch.

> #include <linux/slab.h>
> #include <linux/types.h>
> #include <uapi/linux/jtag.h>