Re: [PATCH v3 0/8] ARM: sun9i: SMP and CPU hotplug support

From: Chen-Yu Tsai
Date: Mon Jan 15 2018 - 23:24:54 EST


On Tue, Jan 16, 2018 at 5:00 AM, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> wrote:
> On Mon, 15 Jan 2018, Chen-Yu Tsai wrote:
>
>> Changes since v2:
>> - Do away with the MCPM framework, directly implement smp_ops
>> - Some debug messages were clarified
>> - New ARCH_SUNXI_MCPM Kconfig symbol for this feature
>
> You should use ARCH_SUNXI_SMP instead to avoid confusion with the actual
> MCPM code. Ditto for function names as Dave mentioned.

All switched to "MC_SMP". There is existing, albeit deprecated, SMP code
for single cluster SoCs, so "multi cluster" is desired to differentiate
from the old stuff.

> For the ARM to Thumb switch you could add something like this at the
> beginning of your entry code:
>
> #ifdef CONFIG_THUMB2_KERNEL
> .arm
> mov ip, #1
> bx ip
> .thumb
> #endif
> [your code follows here]
>
> And make sure that code is word aligned.

Thanks for the tip. As I mentioned in my reply to Dave,
this wasn't really needed.

Thanks again!
ChenYu