Re: [PATCH] mm/compaction: fix the comment for try_to_compact_pages

From: Vlastimil Babka
Date: Wed Jan 17 2018 - 03:43:54 EST


On 01/13/2018 12:55 AM, Yang Shi wrote:
> "mode" argument is not used by try_to_compact_pages() and sub functions
> anymore, it has been replaced by "prio". Fix the comment to explain the
> use of "prio" argument.
>
> Cc: Vlastimil Babka <vbabka@xxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
> Cc: David Rientjes <rientjes@xxxxxxxxxx>
> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

> ---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 10cd757..2c8999d 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1738,7 +1738,7 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,
> * @order: The order of the current allocation
> * @alloc_flags: The allocation flags of the current allocation
> * @ac: The context of current allocation
> - * @mode: The migration mode for async, sync light, or sync migration
> + * @prio: Determines how hard direct compaction should try to succeed
> *
> * This is the main entry point for direct page compaction.
> */
>