Re: [REGRESSION] linux-next panics when trying to mount root

From: RafaÅ MiÅecki
Date: Wed Jan 17 2018 - 04:45:40 EST


On 2018-01-16 16:30, Boris Brezillon wrote:
On Tue, 16 Jan 2018 16:02:35 +0100
Peter Rosin <peda@xxxxxxxxxx> wrote:

On 2018-01-16 15:21, Boris Brezillon wrote:
> On Tue, 16 Jan 2018 14:56:52 +0100
> Peter Rosin <peda@xxxxxxxxxx> wrote:
>
>> Hmmm, I guess the question is if the command line should override the
>> device tree or not?
>
> Yep, that's the problem. Now the core parses the compatible to decides
> which part parser should be used. The thing is, the "cmdline" parser is
> not yet exposing a compatible id, and even if it was, this would
> require patching all DTs to add this new compatible.
>
> partitions {
> compatible = "cmdline", "fixed-partitions";
> ...
> };
>
> Not really an option, so I'll drop the 2 patches for now until we find a
> better solution.
>
>> I'm going to send a patch for the above dts change either way...
>
> If you want, but that does not solve the problem: we should not break
> existing users.

Well, don't let these devices stop you, they will not get a new kernel
w/o also getting a new dtb, and I can handle this just fine. But maybe
I'm just the first reporter and you'd rather not risk anything? Anyway,
just wanted to let you know where I stand...

Unfortunately, at91 is not the only platform to have "fixed-partitions"
defined in its DTs, and I guess users of other platforms also like to
override the default MTD layout by their own using mtdparts.I'd like to
find a solution that keeps everyone happy.

I absolutely agree with Boris, we can't risk such regressions. That had to
be dropped and I'm looking for a better solution.