Re: [PATCH v4 1/2] nvme: add tracepoint for nvme_setup_cmd

From: Christoph Hellwig
Date: Mon Jan 22 2018 - 11:10:32 EST


On Mon, Jan 22, 2018 at 05:04:37PM +0100, Johannes Thumshirn wrote:
> You mean like:
> if (ns)
> trace_nvme_setup_cmd(cmd);
> else
> trace_nvme_setup_admin_cmd(cmd);
>
> ?

Yes. Although I'd rename trace_nvme_setup_cmd to trace_nvme_setup_nvm_cmd
to prepare for new I/O command sets.