RE: [PATCH 3/3] tpm: add longer timeouts for creation commands.

From: Winkler, Tomas
Date: Wed Jan 24 2018 - 16:29:31 EST




> -----Original Message-----
> From: Jarkko Sakkinen [mailto:jarkko.sakkinen@xxxxxxxxxxxxxxx]
> Sent: Tuesday, January 23, 2018 15:12
> To: Winkler, Tomas <tomas.winkler@xxxxxxxxx>
> Cc: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>; Usyskin,
> Alexander <alexander.usyskin@xxxxxxxxx>; tpmdd-
> devel@xxxxxxxxxxxxxxxxxxxxx; linux-integrity@xxxxxxxxxxxxxxx; linux-security-
> module@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 3/3] tpm: add longer timeouts for creation commands.
>
> On Tue, Jan 23, 2018 at 01:27:31PM +0200, Tomas Winkler wrote:
> > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve
> > generation of crypto keys which can be a computationally intensive task.
> > The timeout is set to 3min.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
>
> From where are these numbers are derived from?

An Intel SW architect.

>
> Can you send 1/3 and 2/3 as a separate patch set with a cover letter (with
> explanation) and this as a separate patch? This is unrelated to first two
> changes albeit might make sense.

Will do, though the patches were born to address the initialization issues we've encountered.
Thanks
Tomas