Re: [PATCH 0/4] MMS114 touchscreen patches

From: Simon Shields
Date: Thu Jan 25 2018 - 08:02:14 EST


Hi Dmitry,

Thanks for the extra fixes!

On Wed, Jan 24, 2018 at 11:38:00AM -0800, Dmitry Torokhov wrote:
> Hi,
>
> This is a combination of couple of my patches + Simons patches dropping
> support for platform data and adding support for mms152, slightly reworked.
>
> Andi, because patches changed a bit I did not add your reviewed-by or
> tested-by, please take another look.
>
> Thanks!
>
> Dmitry Torokhov (2):
> Input: mms114 - do not clobber interrupt trigger
> Input: mms114 - mark as direct input device
>
> Simon Shields (2):
> Input: mms114 - drop platform data and use generic APIs
> Input: mms114 - add support for mms152
>
> .../bindings/input/touchscreen/mms114.txt | 35 ++--
> drivers/input/touchscreen/mms114.c | 229 ++++++++++++---------
> include/linux/platform_data/mms114.h | 24 ---
> 3 files changed, 151 insertions(+), 137 deletions(-)
> delete mode 100644 include/linux/platform_data/mms114.h
>
> --
> Dmitry
>

All looks good to me. Tested on MMS114 and MMS152.

Reviewed-by: Simon Shields <simon@xxxxxxxxxxxxx>
Tested-by: Simon Shields <simon@xxxxxxxxxxxxx>

Cheers,
Simon