Re: [Patch v1 0/8] platform/x86: intel_pmc_core: Add CFL/CNL Support

From: Andy Shevchenko
Date: Fri Jan 26 2018 - 07:46:14 EST


On Fri, Jan 19, 2018 at 10:58 AM, Rajneesh Bhardwaj
<rajneesh.bhardwaj@xxxxxxxxx> wrote:
> This series is the successor to
> https://www.spinics.net/lists/platform-driver-x86/msg14524.html and adds
> support for Intel Coffeelake and Cannonlake SoCs.
>
> This also presents an alternative to https://lkml.org/lkml/2017/11/17/876
> and introduces Cannonlake SoC to intel-family.h
>
> The following patches,
>
> '0003-ACPI-LPIT-Export-lpit_read_residency_count_address.patch' and
> '0006-x86-cpu-Add-Cannonlake-to-Intel-family.patch'
>
> do not belong to platform-drivers-x86 subsystem but the other patches in the
> series depend on them so, requesting the respective MAINTAINERS for their
> review and ACK so that these two patches can also go through the
> platform-drivers-x86 subsystem.

I have applied 1,2, and 5 to my review and testing queue, thanks!

P.S. Please, rebase and sent new version when patches 3 and 6 will get ACKa

> Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Cc: linux-acpi@xxxxxxxxxxxxxxx
>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
>
> Tested on Coffeelake, Cannonlake and Kabylake with 4.15-rc8 kernel.
>
> Rajneesh Bhardwaj (5):
> platform/x86: intel_pmc_core: Refactor debugfs entries
> platform/x86: intel_pmc_core: Convert to ICPU macro
> x86/cpu: Add Cannonlake to Intel family
> platform/x86: intel_pmc_core: Add CannonLake PCH support
> platform/x86: intel_pmc_core: Special case for Coffeelake
>
> Srinivas Pandruvada (3):
> platform/x86: intel_pmc_core: Substitute PCI with CPUID enumeration
> ACPI / LPIT: Export lpit_read_residency_count_address()
> platform/x86: intel_pmc_core: Read base address from LPIT
>
> arch/x86/include/asm/intel-family.h | 6 +
> drivers/acpi/acpi_lpit.c | 1 +
> drivers/platform/x86/intel_pmc_core.c | 242 +++++++++++++++++++++-------------
> drivers/platform/x86/intel_pmc_core.h | 14 +-
> 4 files changed, 174 insertions(+), 89 deletions(-)


--
With Best Regards,
Andy Shevchenko