Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig

From: LABBE Corentin
Date: Fri Jan 26 2018 - 07:49:49 EST


On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@xxxxxxxxxxxx> wrote:
> > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support")
> > > Lets remove this kconfig option.
> >
> > First of all, I hardly understand how that change is related.
> > Second, did you check Makefile?
>
> I don't see it being used in any Makefile, what file do you see it:
> $ git grep VIDEO_ATOMISP_OV8858
> drivers/staging/media/atomisp/i2c/Kconfig:config VIDEO_ATOMISP_OV8858
>
> So it should be removed.
>
> thanks,
>

Hello

I just see that 3a81c7660f80 left ov8858.c so do you agree that I send a v2 which remove also this file ?
av8858.c is useless without dw9718.c and vcm.c which 3a81c7660f80 removed.

Regards