Re: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static

From: David Miller
Date: Fri Jan 26 2018 - 11:13:08 EST


From: Edward Cree <ecree@xxxxxxxxxxxxxx>
Date: Fri, 26 Jan 2018 15:13:05 +0000

> On 26/01/18 01:03, kbuild test robot wrote:
>> Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
>> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Acked-by: Edward Cree <ecree@xxxxxxxxxxxxxx>
>
> Dave, can you take this directly or do you need it reposted without RFC tags?  I'm not sure what the procedure is for robopatches.

No I cannot.

Don't you even notice that the subject line and commit message are
totally inaccurate?

They say that one function is being marked static.

But the patch actually marks two different functions static, as well
as a structure which is also completely not mentioned in the commit
message nor subject line.