Re: [linux-sunxi] Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

From: Yong
Date: Sat Jan 27 2018 - 21:20:02 EST


Hi Maxime,

On Fri, 26 Jan 2018 09:10:00 +0100
Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:

> On Fri, Jan 26, 2018 at 11:00:41AM +0800, Yong wrote:
> > Hi Maxime,
> >
> > On Fri, 26 Jan 2018 09:46:58 +0800
> > Yong <yong.deng@xxxxxxxxxxxx> wrote:
> >
> > > Hi Maxime,
> > >
> > > Do you have any experience in solving this problem?
> > > It seems the PHYS_OFFSET maybe undeclared when the ARCH is not arm.
> >
> > Got it.
> > Should I add 'depends on ARM' in Kconfig?
>
> Yes, or even better a depends on MACH_SUNXI :)

Do you mean ARCH_SUNXI?

ARCH_SUNXI is alreay there. In the early version, my Kconfig is like this:

depends on ARCH_SUNXI

But Hans suggest me to change this to:

depends on ARCH_SUNXI || COMPILE_TEST

to allow this driver to be compiled on e.g. Intel for compile testing.

Should we get rid of COMPILE_TEST?

Yong