Re: [PATCH v2 1/2] x86/acpi: add retrieval function for rsdp address

From: Rafael J. Wysocki
Date: Sun Jan 28 2018 - 22:01:56 EST


On Fri, Jan 26, 2018 at 7:08 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Jan 25, 2018 at 4:36 PM, Juergen Gross <jgross@xxxxxxxx> wrote:
>> Add a function to get the address of the RSDP table. Per default use a
>> __weak annotated function being a nop.
>
> The problem with weak functions that we can't have more than one
> implementation per kernel while we would like to built several code
> paths.
>
> I have stumbled on the similar stuff and realize that.
>
> Perhaps, one of the solution is to have an additional struct under
> x86_init to alternate ACPI related stuff.

I'm not sure if that really is a problem in this particular case.

Why would you want to use different RSDP retrieval functions for one arch?

Thanks,
Rafael