Re: [PATCH v7] Support intel-vbtn based tablet mode switch

From: Marco Martin
Date: Mon Jan 29 2018 - 15:33:29 EST


On Mon, Jan 29, 2018 at 8:35 PM, <Mario.Limonciello@xxxxxxxx> wrote:
>> -----Original Message-----
>> From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx]
>> Sent: Monday, January 29, 2018 12:57 PM
>> To: Marco Martin <notmart@xxxxxxxxx>
>> Cc: Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx>; Limonciello, Mario
>> <Mario_Limonciello@xxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxxxxx>; Pali
>> RohÃr <pali.rohar@xxxxxxxxx>; Darren Hart <dvhart@xxxxxxxxxxxxx>; Matthew
>> Garrett <mjg59@xxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
>> kernel@xxxxxxxxxxxxxxx>; Bhushan Shah <bhush94@xxxxxxxxx>
>> Subject: Re: [PATCH v7] Support intel-vbtn based tablet mode switch
>>
>> On Sat, Jan 27, 2018 at 6:35 PM, Marco Martin <notmart@xxxxxxxxx> wrote:
>> > Some laptops such as Dell Inspiron 7000 series have the
>> > tablet mode switch implemented in Intel ACPI,
>> > the events to enter and exit the tablet mode are 0xCC and 0xCD
>> >
>>
>> It doesn't apply :-(
>
> Marco, I can see it applies on 4.15 but it's not applying on platform-drivers-x86/testing.
> It's most likely this commit you need to rebase on top of:

Ah, i see (i was trying on platform-drivers-x86 but master branch, sorry)
latest version is rebased on top of it, i seen the reason it didn't
apply was that the addition
to sparse_keymap was already done in 1c8284 by Stefan BrÃns (whoops :)
However still needs the initialization part, so booting or
modprobe with the device already in tablet mode would initialize the
correct state

--
Marco Martin