Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device for BOSC0200

[Hans de Goede]

Hi,

On 31-01-18 13:25, Andy Shevchenko wrote:
> Have you chance a look at the branch I pushed yesterday?

I assume you mean:

https://bitbucket.org/andy-shev/linux/branch/topic/iio-acpi

This looks very nice and a much better solution then what
Jeremy Cline posted, which is my fault as I suggested that
approach to Jeremy :)

I've not done a full review, only a quick look, from a quick
look this looks good. Especially from a code-design pov.

Regards,

Hans



> > For reference here is the relevant DSDT blurb from the Yoga 11e:
>
> Yes, I have googled something like this yesterday, but it doesn't
> clarify what kind of devices behind this entry.
>
> >              Device (ACC)
> >              {
> >                  Name (_ADR, Zero)  // _ADR: Address
> >                  Name (_HID, "BOSC0200")  // _HID: Hardware ID
> >                  Name (_CID, "BOSC0200")  // _CID: Compatible ID
> >                  Name (_DDN, "Accelerometer")  // _DDN: DOS Device Name
> >                  Name (_UID, One)  // _UID: Unique ID
> >                  Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource
> > Settings
> >                  {
> >                      Name (RBUF, ResourceTemplate ()
> >                      {
> >                          I2cSerialBusV2 (0x0019, ControllerInitiated,
> > 0x00061A80,
> >                              AddressingMode7Bit, "\\_SB.PCI0.I2C3",
> >                              0x00, ResourceConsumer, , Exclusive,
> >                              )
> >                          I2cSerialBusV2 (0x0018, ControllerInitiated,
> > 0x00061A80,
> >                              AddressingMode7Bit, "\\_SB.PCI0.I2C3",
> >                              0x00, ResourceConsumer, , Exclusive,
> >                              )
> >                      })
> >                      Return (RBUF) /* \_SB_.PCI0.I2C3.ACC_._CRS.RBUF */
> >
> >                  }