Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

From: Andy Shevchenko
Date: Wed Jan 31 2018 - 11:56:50 EST


On Wed, Jan 31, 2018 at 6:20 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> Hi Daniel,

Fabio, +1 to your review. It seems it repeats some of the points I made.


>> + ak5558->pdn_gpio = of_get_named_gpio(np, "ak5558,pdn-gpio", 0);
>
> It does not match the property in the binding doc: asahi-kasei,pdn-gpios

Btw, it must be simple "reset" as a widely used for the same purpose.

--
With Best Regards,
Andy Shevchenko