Re: [PATCH] net: bridge: Fix uninitialized error in br_fdb_sync_static()

From: David Miller
Date: Thu Feb 01 2018 - 09:48:12 EST


From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Thu, 1 Feb 2018 11:25:27 +0100

> With gcc-4.1.2.:
>
> net/bridge/br_fdb.c: In function ʽbr_fdb_sync_staticʼ:
> net/bridge/br_fdb.c:996: warning: ʽerrʼ may be used uninitialized in this function
>
> Indeed, if the list is empty, err will be uninitialized, and will be
> propagated up as the function return value.
>
> Fix this by preinitializing err to zero.
>
> Fixes: eb7935830d00b9e0 ("net: bridge: use rhashtable for fdbs")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Applied, thanks Geert.