Re: [PATCH arm/aspeed/ast2500 v5 1/2] ipmi: add a KCS IPMI BMC driver

[Wang, Haiyue]

On 2018-02-02 21:52, Corey Minyard wrote:
> On 02/01/2018 08:16 PM, Haiyue Wang wrote:
> > ---
> > v4->v5
> > - Fix -Wdiscarded-qualifiers 'const' compile warning.
> > - Fix size_t printk compile error.
> >
> > v3->v4
> > - Change to accept WRITE_START any time.
> >
> > v2->v3
> >
> > - Update the KCS phase state machine.
> > - Fix the race condition of read/write.
> >
> > v1->v2
> >
> > - Divide the driver into two parts, one handles the BMC KCS IPMI 2.0 
> > state;
> > ÂÂ the other handles the BMC KCS controller such as AST2500 IO 
> > accessing.
> > - Use the spin lock APIs to handle the device file operations and BMC 
> > chip
> > ÂÂ IRQ inferface for accessing the same KCS BMC data structure.
> > - Enhanced the phases handling of the KCS BMC.
> > - Unified the IOCTL definition for IPMI BMC, it will be used by KCS 
> > and BT.
> >
> >
> > Provides a device driver for the KCS (Keyboard Controller Style)
> > IPMI interface which meets the requirement of the BMC (Baseboard
> > Management Controllers) side for handling the IPMI request from
> > host system software.
>
> Ok, this is in my queue, it will go into next once 4.16-rc1 comes out, 
> then into
> 4.16 if all goes well.
>
> Thanks, for your patience and work on this.
*Really appreciate your time on the code review, I really learned more, 
thank you. :-)

-- Haiyue
*
> -corey