Re: [PATCH 1/2] GCC release 8 support for gcc-plugins

From: Kees Cook
Date: Mon Feb 05 2018 - 19:54:32 EST


On Mon, Feb 5, 2018 at 4:01 AM, <valdis.kletnieks@xxxxxx> wrote:
> GCC requires another #include to get the gcc-plugins to build cleanly.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@xxxxxx>
>
> diff --git a/scripts/gcc-plugins/gcc-common.h b/scripts/gcc-plugins/gcc-common.h
> index ffd1dfaa1cc1..f46750053377 100644
> --- a/scripts/gcc-plugins/gcc-common.h
> +++ b/scripts/gcc-plugins/gcc-common.h
> @@ -97,6 +97,10 @@
> #include "predict.h"
> #include "ipa-utils.h"
>
> +#if BUILDING_GCC_VERSION >= 8000
> +#include "stringpool.h"
> +#endif
> +
> #if BUILDING_GCC_VERSION >= 4009
> #include "attribs.h"
> #include "varasm.h"

Thanks! I can confirm this works for me. I'll get it applied.

-Kees

--
Kees Cook
Pixel Security