Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

From: Robin Murphy
Date: Wed Feb 07 2018 - 07:39:04 EST


On 06/02/18 13:14, Hans Verkuil wrote:
[...]
The one thing that I worry about is if these structs are the same for
32 and 64 bit arm.

I see some enums and bools in there - in general the storage size of those isn't even guaranteed to be consistent between different compiler implementations on the same platform, let alone across multiple platforms (especially WRT things like GCC's -fshort-enums).

In practice, under the standard ABIs for 32-bit and 64-bit Arm[1], I'd expect basic types other than longs and pointers to be pretty much the same; it's the imp-def C stuff I'd be a lot less confident about.

Robin.

[1]:http://infocenter.arm.com/help/topic/com.arm.doc.subset.swdev.abi/index.html