Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

From: Bin Liu
Date: Wed Feb 07 2018 - 21:38:18 EST


Maxim,

On Fri, Jan 26, 2018 at 12:24:54PM +0300, Maxim Uvarov wrote:
> Bin,
>
> I looked to my local git and code does not have this latest line "goto
> finish". It was tested without it and everything worked. Right now I
> can not get access to that hardware to check with and without. But
> only can confirm that without "goto finish" function works with bunch
> of drivers (usb ethernet, hids, hdd).

Thanks for the confirmation. The revert patch has been sent out.

Regards,
-Bin.

>
> Best regards,
> Maxim.
>
> 2018-01-25 19:31 GMT+03:00 Bin Liu <b-liu@xxxxxx>:
> > Maxim,
> >
> > On Thu, Jan 25, 2018 at 07:24:02PM +0300, Maxim Uvarov wrote:
> >> [1] says that issue is with back ported driver to 3.12.10. Can the
> >> latest kernel be tested on the same hw?
> >
> > Agreed that it should be tested with the latest kernel. But my concern
> > now is if stopping scheduling urbs on errors is a right thing to do,
> > that is why I asked if you can re-test your usecase with reverting the
> > commit. I am unable to reproduce the original issue you had.
> >
> > Thanks,
> > -Bin.
>
>
>
> --
> Best regards,
> Maxim Uvarov