Re: [RFC PATCH 4/7] kconfig: support new special property shell=

From: Linus Torvalds
Date: Sat Feb 10 2018 - 15:08:34 EST


On Sat, Feb 10, 2018 at 11:23 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> So, if this could do something like this:
>
> config CC_HAS_STACKPROTECTOR_STRONG
> bool
> option
> shell="scripts/gcc-${ARCH}_${BITS}-has-stack-protector.sh $CC
> $KBUILD_CPPFLAGS"

Guys, this is not that important.

Don't make some stupid script for stackprotector. If the user doesn't
have a gcc that supports -fstackprotector-*, then don't show the
options. It matters NOT ONE WHIT whether that then means that
stackprotector will be off by default later.

Seriously. This is classic "Kees thinks that _his_ code is so
important that everybody should get the value _he_ cares about".

That's bullshit. Kees, get over yourself. It's a very common thing to
see, but it's WRONG. The fact that _you_ care about this doesn't mean
that everybody else should too.

The whole point was to simplify Kconfig, not to make it even worse.

Linus