Re: [PATCH v2 4/8] objtool: Retpoline validation tweaks

From: David Woodhouse
Date: Mon Feb 12 2018 - 07:58:05 EST




On Mon, 2018-02-12 at 13:48 +0100, Peter Zijlstra wrote:
> --- a/Makefile
> +++ b/Makefile
> @@ -486,6 +486,11 @@ KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG
> ÂKBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
> Âendif
> Â
> +ifneq ($(call cc-option,-mindirect-branch=thunk-extern -mindirect-branch-register),)
> +Â CC_HAS_RETPOLINE := 1
> +endif
> +export CC_HAS_RETPOLINE

Can't you do that with the existing check in arch/x86/Makefile?Â

cf.Âhttp://git.infradead.org/users/dwmw2/linux-retpoline.git/commitdiff/eb12299ed
which is going nowhere until https://bugs.llvm.org/show_bug.cgi?id=36329
gets fixed but still I'd like to have the check in *one* place.

Attachment: smime.p7s
Description: S/MIME cryptographic signature