Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

From: Patrick Bellasi
Date: Thu Feb 15 2018 - 11:59:54 EST


On 15-Feb 17:50, Peter Zijlstra wrote:
> On Thu, Feb 15, 2018 at 03:22:47PM +0000, Patrick Bellasi wrote:
> > > > static struct {
> > > > cpumask_var_t idle_cpus_mask;
> > > > atomic_t nr_cpus;
> > > > + int has_blocked; /* Idle CPUS has blocked load */
> >
> > Why not "bool"?
> >
> Because then he gets me yelling that sizeof(_Bool) is undefined and the
> whole structure layout goes out the window :-)

Now I know...

> Never use bool in a composite type.

... got a note ;-)

--
#include <best/regards.h>

Patrick Bellasi