Re: [PATCH][next] HID: asus: make array 'buf' static const, shrinks object size

From: Jiri Kosina
Date: Fri Feb 16 2018 - 07:35:19 EST


On Sat, 6 Jan 2018, Colin King wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate the const read-only array 'buf' on the stack but instead
> make it stati. Makes the object code smaller by 26 bytes:
>
> Before:
> text data bss dec hex filename
> 14378 2384 64 16826 41ba linux/drivers/hid/hid-asus.o
>
> After:
> text data bss dec hex filename
> 14296 2440 64 16800 41a0 linux/drivers/hid/hid-asus.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied to for-4.17/upstream.

--
Jiri Kosina
SUSE Labs