Re: [PATCH 04/12] usb: common: Small class for USB role switches

From: Randy Dunlap
Date: Fri Feb 16 2018 - 13:33:53 EST


On 02/16/2018 02:47 AM, Hans de Goede wrote:
> From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>

> diff --git a/drivers/usb/common/roles.c b/drivers/usb/common/roles.c
> new file mode 100644
> index 000000000000..923e3721d183
> --- /dev/null
> +++ b/drivers/usb/common/roles.c
> @@ -0,0 +1,305 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/**

Just use /* since this is not kernel-doc notation.

> + * USB Role Switch Support
> + *
> + * Copyright (C) 2018 Intel Corporation
> + * Author: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> + * Hans de Goede <hdegoede@xxxxxxxxxx>
> + */


--
~Randy