Re: [PATCH 2/2] cpufreq: powernow-k8: Delete an unnecessary return statement in two functions

From: Viresh Kumar
Date: Sun Feb 18 2018 - 22:44:36 EST


On 15-02-18, 20:30, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 15 Feb 2018 20:14:32 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: void function return statements are not generally useful
>
> Thus remove such a statement in the affected functions.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/cpufreq/powernow-k8.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index 460bf22a8a2b..782a8c2a359d 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -122,14 +122,12 @@ static int query_current_values_with_pending_wait(struct powernow_k8_data *data)
> static void count_off_irt(struct powernow_k8_data *data)
> {
> udelay((1 << data->irt) * 10);
> - return;
> }
>
> /* the voltage stabilization time */
> static void count_off_vst(struct powernow_k8_data *data)
> {
> udelay(data->vstable * VST_UNITS_20US);
> - return;
> }
>
> /* need to init the control msr to a safe value (for each cpu) */

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh